Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add split-grapheme-cluster and string normalization function #417

Merged
merged 9 commits into from
Apr 7, 2024

Conversation

puripuri2100
Copy link
Contributor

  • Add split-grapheme-cluster : string -> string list
  • String normalization when parsing strings and inline-text

@gfngfn
Copy link
Owner

gfngfn commented Oct 5, 2023

Thanks for making a PR! It looks basically good!

I think the following API for strings may be a better formalization:

  • val normalize-string-to-nfc : string -> string
  • val normalize-string-to-nfd : string -> string

in that this:

  • allows users to use other normalization forms than NFC, such as NFD, and
  • does not require that string values are always internally NFC, and thereby keeps the implementation less error-prone.

Would you agree with this kind of API design?

@puripuri2100
Copy link
Contributor Author

I agree it. I fixed the code.

@gfngfn gfngfn added this to the v0.0.12 milestone Apr 6, 2024
@gfngfn gfngfn changed the base branch from dev-0-1-0 to dev-0-0-12 April 7, 2024 06:47
@gfngfn gfngfn changed the base branch from dev-0-0-12 to dev-0-1-0 April 7, 2024 06:49
@gfngfn gfngfn modified the milestones: v0.0.12, v0.1.0 Apr 7, 2024
@gfngfn
Copy link
Owner

gfngfn commented Apr 7, 2024

I've re-read this PR and found it to be basically good. Thank you!

@gfngfn gfngfn merged commit e9bf9bb into gfngfn:dev-0-1-0 Apr 7, 2024
6 checks passed
@gfngfn gfngfn mentioned this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants