🤖 Handle Unsupported Compression Methods in GZipStream Operations #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sentry-autofix[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
bruno-garcia
reviewed
Apr 8, 2024
| _logger.LogError(ex, "Unsupported compression method encountered."); | ||
| modelState.AddModelError("File", "Unsupported compression method."); | ||
| code = HttpStatusCode.UnsupportedMediaType; | ||
| return (null, null, code); |
There was a problem hiding this comment.
Not sure if this is right given there's a final return at the end for failure modes
There was a problem hiding this comment.
Also CI is unhappy here, PR didn't take nullability into account:
/Users/runner/work/symbol-collector/symbol-collector/src/SymbolCollector.Server/SymbolsController.cs(337,28): error CS8619: Nullability of reference types in value of type '(string?, Stream?, HttpStatusCode? code)' doesn't match target type '(string fileName, Stream data, HttpStatusCode? code)'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hi there! This PR was automatically generated 🤖
Triggered by bruno@sentry.io
Fixes ANDROID-SYMBOL-COLLECTOR-SERVER-68
The issue arises from an InvalidDataException during the decompression process in a GZipStream operation, indicating an unsupported compression method. To resolve this, we will implement a try-catch block around the GZipStream operation in the ProcessStreamedFile method of the SymbolsController. This will catch the InvalidDataException and log an appropriate error message, allowing the system to handle unsupported compression methods gracefully.
The steps that were performed:
📣 Instructions for the reviewer which is you, yes you:
This will greatly help us improve the autofix system. Thank you! 🙏
If there are any questions, please reach out to the AI/ML Team on #proj-autofix
🤓 Stats for the nerds:
Prompt tokens: 26409
Completion tokens: 1227
Total tokens: 27636