chore: Add UE 4.27, 5.0 and 5.1 to CI pipeline #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
approved these changes
Nov 1, 2024
| @@ -74,7 +74,7 @@ void PrintVerboseLog(sentry_level_t level, const char *message, va_list args, vo | |||
|
|
|||
| void PrintCrashLog(const sentry_ucontext_t *uctx) | |||
| { | |||
| #if PLATFORM_WINDOWS | |||
| #if PLATFORM_WINDOWS && ENGINE_MAJOR_VERSION == 5 | |||
There was a problem hiding this comment.
How about this so if/when 6 lands, it's included automatically? (I assume nothign would work on UE3 anyway)?
Suggested change
| #if PLATFORM_WINDOWS && ENGINE_MAJOR_VERSION == 5 | |
| #if PLATFORM_WINDOWS && ENGINE_MAJOR_VERSION != 4 |
There was a problem hiding this comment.
Since we have quite a few places with the version-specific code I've created a separate issue to track this request - #676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the plugin stays backward compatible with some older Unreal versions (including UE 4.27) and addresses minor build errors that were revealed during testing.
The plugin will continue to support at least the latest three Unreal Engine versions to comply with Marketplace guidelines while the decision to drop support for older ones may be influenced by the outcome of #664.
It's also worth noticing that the corresponding packages will be added to the release page.
Closes #661
Related to #575