Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpenAI tests #3738

Open
wants to merge 1 commit into
base: potel-base
Choose a base branch
from
Open

Fix OpenAI tests #3738

wants to merge 1 commit into from

Conversation

antonpirker
Copy link
Member

No description provided.

@antonpirker antonpirker changed the base branch from master to potel-base November 5, 2024 14:27
antonpirker
antonpirker commented Nov 5, 2024
View reviewed changes
tests/integrations/openai/test_openai.py
@@ -330,6 +330,7 @@ async def test_streaming_chat_completion_async(
pass # if tiktoken is not installed, we can't guarantee token usage will be calculated properly


@pytest.mark.forked
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fork tests that capture exceptions. (Somehow capturing exceptions messes up the next sentry_sdk.init() and capturing events/exeptions in following tests)

@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024

❌ 40 Tests Failed:

Tests completed Failed Passed Skipped
110 40 70 0
View the full list of 3 ❄️ flaky tests 
tests.integrations.aws_lambda.test_aws test_non_dict_event[python3.9-\n            [\n                {\n                    "headers": {\n                        "Host": "x1.io",\n                        "X-Forwarded-Proto": "https"\n                    },\n                    "httpMethod": "GET",\n                    "path": "/path1",\n                    "queryStringParameters": {\n                        "done": "false"\n                    },\n                    "dog": "Maisey"\n                },\n                {\n                    "headers": {\n                        "Host": "x2.io",\n                        "X-Forwarded-Proto": "http"\n                    },\n                    "httpMethod": "POST",\n                    "path": "/path2",\n                    "queryStringParameters": {\n                        "done": "true"\n                    },\n                    "dog": "Charlie"\n                }\n            ]\n            -True-2]

Flake rate in main: 60.00% (Passed 4 times, Failed 6 times)

Stack Traces | 0.185s run time 
.../integrations/aws_lambda/test_aws.py:522: in test_non_dict_event
    assert error_event["transaction"] == function_name
E   KeyError: 'transaction'

tests.integrations.aws_lambda.test_aws test_non_dict_event[python3.11-[]-False-1]

Flake rate in main: 60.00% (Passed 4 times, Failed 6 times)

Stack Traces | 0.187s run time 
.../integrations/aws_lambda/test_aws.py:522: in test_non_dict_event
    assert error_event["transaction"] == function_name
E   KeyError: 'transaction'

tests.integrations.aws_lambda.test_aws test_non_dict_event[python3.9-\n            [\n                {"good dog": "Maisey"},\n                {"good dog": "Charlie"},\n                {"good dog": "Cory"},\n                {"good dog": "Bodhi"}\n            ]\n            -False-4]

Flake rate in main: 60.00% (Passed 4 times, Failed 6 times)

Stack Traces | 0.19s run time 
.../integrations/aws_lambda/test_aws.py:522: in test_non_dict_event
    assert error_event["transaction"] == function_name
E   KeyError: 'transaction'

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
Project: POTel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonpirker @sentrivana