Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stacktrace context to inline code #65

Merged
merged 8 commits into from
Oct 23, 2024
Merged

feat: add stacktrace context to inline code #65

merged 8 commits into from
Oct 23, 2024

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Oct 22, 2024

This adds source context for frames present in the original script code, e.g. by running pwsh -c '{& ... }'. It should also work for situations when the script is launched directly without a ps1 file, e.g. from Azure automation workers

Copy link
Contributor

github-actions bot commented Oct 22, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- add stacktrace context to inline code ([#65](https://github.com/getsentry/sentry-powershell/pull/65))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 13ef514

@vaind vaind changed the title fix: stacktrace parsing feat: add stacktrace context to inline code Oct 23, 2024
Describe 'Out-Sentry captures expected stack traces for PowerShell.Create()' {
BeforeEach {
Push-Location "$PSScriptRoot/.."
$expected = @(

Check warning

Code scanning / PSScriptAnalyzer

The variable 'expected' is assigned but never used. Warning test

The variable 'expected' is assigned but never used.
@vaind vaind marked this pull request as ready for review October 23, 2024 13:38
@vaind vaind merged commit bc2d65b into main Oct 23, 2024
13 of 14 checks passed
@vaind vaind deleted the fix/stacktrace branch October 23, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant