Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DLL versioning for SDK usage as CMake subdirectory #1086

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

supervacuus
Copy link
Collaborator

This should fix the issue raised in #1084.

@dacap, can you give this a try in your setup?

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.36%. Comparing base (4e61614) to head (0c713ae).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1086      +/-   ##
==========================================
- Coverage   82.41%   82.36%   -0.06%     
==========================================
  Files          53       53              
  Lines        7751     7751              
  Branches     1216     1216              
==========================================
- Hits         6388     6384       -4     
- Misses       1251     1254       +3     
- Partials      112      113       +1     
---- 🚨 Try these New Features:

@dacap
Copy link

dacap commented Nov 20, 2024

@supervacuus it worked! thanks for the fix 👍

Copy link
Member

@JoshuaMoelans JoshuaMoelans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@supervacuus supervacuus merged commit f1699e1 into master Nov 20, 2024
24 checks passed
@supervacuus supervacuus deleted the fix/dll_versioning_cmake_add_subdirectory branch November 20, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants