test: add special case for Windows Autoproxy

getsentry · Nov 15, 2024 · 1e0f1c8 · 1e0f1c8
1 parent 63f2f58
commit 1e0f1c8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/tests/test_integration_crashpad.py b/tests/test_integration_crashpad.py
@@ -97,7 +97,6 @@ def test_crashpad_crash_proxy(cmake, httpserver, run_args, proxy_status):
             elif run_args == ["socks5-proxy"] and proxy_status == ["off"]:
                 # Apple's NSURLSession will send the request even if the socks proxy fails
                 # https://forums.developer.apple.com/forums/thread/705504?answerId=712418022#712418022
-                # hence there is no (socks5-proxy, off) tuple in the AssertionError catch above
                 assert len(httpserver.log) == (1 if (sys.platform == "darwin") else 0)
                 return
 

diff --git a/tests/test_integration_http.py b/tests/test_integration_http.py
@@ -662,7 +662,9 @@ def test_capture_proxy(cmake, httpserver, run_args, proxy_status):
         if proxy_status == ["on"]:
             assert len(httpserver.log) == 2
         elif proxy_status == ["off"]:
-            assert len(httpserver.log) == 0
+            # Window's Autoproxy will send the request even if the http proxy fails
+            # https://learn.microsoft.com/en-us/windows/win32/winhttp/winhttp-autoproxy-support
+            assert len(httpserver.log) == (2 if (sys.platform == "win32") else 0)
     finally:
         if proxy_process:
             proxy_process.terminate()