Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(self-hosted): external storage #10884

Merged

Conversation

aldy505
Copy link
Contributor

@aldy505 aldy505 commented Jul 27, 2024

DESCRIBE YOUR PR

Dupe of getsentry/develop#1269, as guessed, self-hosted docs is not 100% complete on what kind of thngs that are possible there. Here is one of the PR to help achieve those.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Jul 27, 2024

@aldy505 is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 8:44pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 8:44pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 8:44pm

@getsantry
Copy link
Contributor

getsantry bot commented Aug 19, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Aug 19, 2024
@aldy505
Copy link
Contributor Author

aldy505 commented Aug 19, 2024

ping @joshuarli @hubertdeng123

@aldy505
Copy link
Contributor Author

aldy505 commented Aug 26, 2024

another ping @hubertdeng123

develop-docs/self-hosted/external-storage.mdx Outdated Show resolved Hide resolved
develop-docs/self-hosted/external-storage.mdx Outdated Show resolved Hide resolved
develop-docs/self-hosted/external-storage.mdx Outdated Show resolved Hide resolved
gs://my-bucket
```

### S3 backend
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see two S3 backend sections here. Should these be combined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It's for different services, should resides on a different bucket.

develop-docs/self-hosted/external-storage.mdx Outdated Show resolved Hide resolved
develop-docs/self-hosted/external-storage.mdx Outdated Show resolved Hide resolved
Co-authored-by: Hubert Deng <hubertdeng123@gmail.com>
@aldy505
Copy link
Contributor Author

aldy505 commented Sep 3, 2024

another ping @hubertdeng123 @joshuarli. no more PR on SH docs in the near future from me.

@aldy505
Copy link
Contributor Author

aldy505 commented Sep 10, 2024

another ping @hubertdeng123 @joshuarli

@getsantry getsantry bot removed the Stale label Sep 10, 2024
@aldy505
Copy link
Contributor Author

aldy505 commented Sep 11, 2024

feedback getsentry/self-hosted#3315 (comment)

@aldy505
Copy link
Contributor Author

aldy505 commented Sep 25, 2024

another feedbacks:

image

image

@aldy505
Copy link
Contributor Author

aldy505 commented Oct 1, 2024

yet another ping @hubertdeng123 @joshuarli

@hubertdeng123 hubertdeng123 merged commit 601041a into getsentry:master Oct 1, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
@aldy505 aldy505 deleted the docs/self-hosted/external-storage branch November 17, 2024 12:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants