feat(unreal): Add check to ensure user info is not empty #4225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
approved these changes
Nov 6, 2024
Co-authored-by: David Herberth <david.herberth@sentry.io>
loewenheim
reviewed
Nov 8, 2024
| @@ -201,7 +201,8 @@ fn merge_unreal_context(event: &mut Event, context: Unreal4Context) { | |||
|
|
|||
| if let Some(login_id) = &runtime_props.login_id { | |||
| let id = event.user.get_or_insert_with(User::default).id.value_mut(); | |||
| if id.is_none() { | |||
|
|
|||
| if id.as_ref().map_or(true, |s| s.is_empty()) { | |||
There was a problem hiding this comment.
I learned of it too late, but this seems a good usecase for Option::is_none_or.
Suggested change
| if id.as_ref().map_or(true, |s| s.is_empty()) { | |
| if id.as_ref().is_none_or(|s| s.is_empty()) { |
There was a problem hiding this comment.
Huh, I remember searching for this a while ago and being annoyed that it doesn't exist, but they added it with 1.82 now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing an issue with a customer where the
login_idis set to an empty string. This tries to fix that by checking that the value we set thelogin_idto from the header is not an empty string and by overwriting thelogin_idvalue from theruntime_propertiesnot only if thelogin_idis none but also if it is an empty string.