Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Allow to pass an instance of ClientSession as an argument. #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kentzo
Copy link

@Kentzo Kentzo commented Oct 23, 2017

Refs #22

@Kentzo
Copy link
Author

Kentzo commented Oct 23, 2017

@asvetlov In this PR I also changed code to always cache ClientSession. Please let me know if this is bad. If so, I'd also like to add a comment to the code.

This is a backward compatible change. I would remove verify_ssl, resolve, timeout, keepalive and family requiring the user to either pass client_session or use default-constructed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant