Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Comment why we can't use cocoapods 1.16.2 #570

Merged
merged 1 commit into from
Nov 22, 2024
Merged

chore: Comment why we can't use cocoapods 1.16.2 #570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
# Pin CocoaPods Version to avoid that bugs in CocoaPods like
# https://github.com/CocoaPods/CocoaPods/issues/12081 break our release
# workflow.
# 1.16.2 has a bug that breaks the release workflow
# 1.16.2 has a bug that breaks the release workflow. Publishing with craft then
# fails with:
# - ERROR | [iOS] unknown: Encountered an unknown error (Unable to locate the
# executable `rsync`) during validation.
Comment on lines +7 to +8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading the error message -- do you not just want to install rsync?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's worth a shot. Is this the right place to add the dependency? If not, where can I add it, @asottile-sentry?

craft/Dockerfile

Lines 28 to 42 in 272a995

RUN apt-get -qq update \
&& apt-get install -y --no-install-recommends \
apt-transport-https \
build-essential \
curl \
default-jdk-headless \
dirmngr \
gnupg \
git \
python3-packaging \
python3-venv \
ruby-full \
jq \
unzip \
maven \

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that would be the place -- you can build the docker image locally and play around with it too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do that before updating CocoaPods. Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created an issue, so I don't forget.

# This could be related to https://github.com/CocoaPods/CocoaPods/issues/12674.
# Therefore, we stick to 1.14.2.
gem "cocoapods", "= 1.14.2"
Loading