Treat object parameters as objects in templating

[lbergnehr]

What does this change

This change makes it possible to access a parameter in templating, not only to the top-level, i.e. the parameter itself, but also -- if the parameter is of type "object" -- to access properties of the object value. For example:

parameters:
  - name: foo
    type: object
    default:
      a: 1
      b: 2

install:
  mymixin:
    some_property: ${ bundle.parameters.foo.a }

In this case, the .a was not possible before as foo was merely a JSON string at the point of template resolution.

What issue does it fix

Closes #1508 (partly?)

Notes for the reviewer

This does not solve the same issue for credentials. I'm not sure if that scenario is as common as with parameters though.

I wasn't sure how to handle sensitive along with a parameter of type object. Right now it's required for the type to be string is sensitive is to work. What would be a good way to handle it? Serialize the object to a string again and then sending it to the sensitive machinery?

Checklist

• Did you write tests?
• Did you write documentation?
• Did you change porter.yaml or a storage document record? Update the corresponding schema file.
• If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

[kichristensen]

@lbergnehr Thank you very much for the PR. Will take a closer look.
Quickly skimming through the related issue, could you add a test that verifies this PR won't change the existing behaviour (unless such a test already exist)? See #1508 (comment)

[lbergnehr]

@lbergnehr Thank you very much for the PR. Will take a closer look. Quickly skimming through the related issue, could you add a test that verifies this PR won't change the existing behaviour (unless such a test already exist)? See #1508 (comment)

Thanks @kichristensen! I added the test and also had to change the implementation to make it pass (great test! :)). There's a caveat in that nested properties will not be interpolated as JSON, but the actual parameter object will (see commit message for more info).

(FYI: the force push was only to add my signature.)

[kichristensen]

Thanks for the update @lbergnehr. I will double-check that the behaviour is the same as in the current version, mean while could you take a look at the failing "Vet and Lint"?

[lbergnehr]

Thanks for the update @lbergnehr. I will double-check that the behaviour is the same as in the current version, mean while could you take a look at the failing "Vet and Lint"?

Thanks for having a look @kichristensen! I think I fixed the linting error (although I couldn't run mage lint locally to verify).