Removing some of the clunkiness with instantiating datastores (#246)

* Upgrade to support .NET 9 and remove support for .NET 6 & 7 Signed-off-by: Martin Pekurny <mpekurny@paychex.com> * Fixed AssemblyLoader unit tests, load step registry before starting service, and reorg loader and refacroring classes Signed-off-by: Martin Pekurny <mpekurny@paychex.com> * Removing some of the clunkiness with setting DataStores Signed-off-by: Martin Pekurny <mpekurny@paychex.com> * Update integration tests projects with lib build 0.12.0 from nuget and rebuild them Signed-off-by: Martin Pekurny <mpekurny@paychex.com> --------- Signed-off-by: Martin Pekurny <mpekurny@paychex.com>
getgauge · Nov 28, 2024 · a35b0bb · a35b0bb
1 parent 75da372
commit a35b0bb
Show file tree

Hide file tree

Showing 120 changed files with 1,422 additions and 4,393 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -26,7 +26,7 @@ jobs:
     - name: Setup .NET Core 
       uses: actions/setup-dotnet@v4
       with:
-        dotnet-version: 8.0.x
+        dotnet-version: 9.0.x
 
     - name: Dotnet unit test on windows
       if: matrix.os == 'windows-latest'
@@ -69,7 +69,7 @@ jobs:
       - name: Setup .NET Core
         uses: actions/setup-dotnet@v4
         with:
-          dotnet-version: 8.0.x
+          dotnet-version: 9.0.x
 
       - uses: getgauge/setup-gauge@master
         with:
@@ -130,7 +130,7 @@ jobs:
       - name: Setup .NET Core
         uses: actions/setup-dotnet@v4
         with:
-          dotnet-version: 8.0.x
+          dotnet-version: 9.0.x
 
       - uses: getgauge/setup-gauge@master
         with:

diff --git a/.github/workflows/release-on-pr-merge.yml b/.github/workflows/release-on-pr-merge.yml
@@ -18,7 +18,7 @@ jobs:
       - name: Setup .NET Core
         uses: actions/setup-dotnet@v4
         with:
-          dotnet-version: 8.0.x
+          dotnet-version: 9.0.x
 
       - name: Setup git
         run: |

diff --git a/_testdata/ReferenceDllProject/ReferenceDll.csproj b/_testdata/ReferenceDllProject/ReferenceDll.csproj
@@ -6,7 +6,7 @@
 
   <ItemGroup>
     <PackageReference Include="FluentAssertions" Version="6.12.2" />
-    <PackageReference Include="Gauge.CSharp.Lib" Version="0.11.3" />
+    <PackageReference Include="Gauge.CSharp.Lib" Version="0.12.0" />
   </ItemGroup>
 
 </Project>
diff --git a/_testdata/ReferenceProject/ReferenceProject.csproj b/_testdata/ReferenceProject/ReferenceProject.csproj
@@ -6,7 +6,7 @@
 
   <ItemGroup>
     <PackageReference Include="FluentAssertions" Version="6.12.2" />
-    <PackageReference Include="Gauge.CSharp.Lib" Version="0.11.3" />
+    <PackageReference Include="Gauge.CSharp.Lib" Version="0.12.0" />
   </ItemGroup>
 
 </Project>
diff --git a/_testdata/Sample/IntegrationTestSample.csproj b/_testdata/Sample/IntegrationTestSample.csproj
@@ -5,6 +5,6 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Gauge.CSharp.Lib" Version="0.11.3" />
+    <PackageReference Include="Gauge.CSharp.Lib" Version="0.12.0" />
   </ItemGroup>
 </Project>
diff --git a/_testdata/Sample/gauge_bin/Gauge.CSharp.Lib.dll b/_testdata/Sample/gauge_bin/Gauge.CSharp.Lib.dll
diff --git a/_testdata/Sample/gauge_bin/IntegrationTestSample.deps.json b/_testdata/Sample/gauge_bin/IntegrationTestSample.deps.json
@@ -8,17 +8,17 @@
     ".NETCoreApp,Version=v8.0": {
       "IntegrationTestSample/1.0.0": {
         "dependencies": {
-          "Gauge.CSharp.Lib": "0.11.1"
+          "Gauge.CSharp.Lib": "0.12.0"
         },
         "runtime": {
           "IntegrationTestSample.dll": {}
         }
       },
-      "Gauge.CSharp.Lib/0.11.1": {
+      "Gauge.CSharp.Lib/0.12.0": {
         "runtime": {
           "lib/net8.0/Gauge.CSharp.Lib.dll": {
-            "assemblyVersion": "0.11.1.0",
-            "fileVersion": "0.11.1.0"
+            "assemblyVersion": "0.12.0.0",
+            "fileVersion": "0.12.0.0"
           }
         }
       }
@@ -30,12 +30,12 @@
       "serviceable": false,
       "sha512": ""
     },
-    "Gauge.CSharp.Lib/0.11.1": {
+    "Gauge.CSharp.Lib/0.12.0": {
       "type": "package",
       "serviceable": true,
-      "sha512": "sha512-QEgfnNnhgPkW+BuXcz4bKN4DsjFWEepIN7gcIs68/STVlejB6LaMYDmrDFdakSVV6G21xWz4U8egSurZsN4RaA==",
-      "path": "gauge.csharp.lib/0.11.1",
-      "hashPath": "gauge.csharp.lib.0.11.1.nupkg.sha512"
+      "sha512": "sha512-C3bYsHzxJznZ9ZLIkiZ8SjoukTkIwG55Ra0Yo9uGl1ynyvHJeVPYQSLkAd6ogPqJl905BFSrQqt6uII0g4vU3g==",
+      "path": "gauge.csharp.lib/0.12.0",
+      "hashPath": "gauge.csharp.lib.0.12.0.nupkg.sha512"
     }
   }
 }
diff --git a/_testdata/Sample/gauge_bin/IntegrationTestSample.dll b/_testdata/Sample/gauge_bin/IntegrationTestSample.dll
diff --git a/_testdata/Sample/gauge_bin/IntegrationTestSample.pdb b/_testdata/Sample/gauge_bin/IntegrationTestSample.pdb
diff --git a/_testdata/SampleDllReference/IntegrationTestSampleDllReference.csproj b/_testdata/SampleDllReference/IntegrationTestSampleDllReference.csproj
@@ -5,7 +5,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Gauge.CSharp.Lib" Version="0.11.3" />
+    <PackageReference Include="Gauge.CSharp.Lib" Version="0.12.0" />
   </ItemGroup>
 
   <ItemGroup>

diff --git a/_testdata/SampleDllReference/StepImplementation.cs b/_testdata/SampleDllReference/StepImplementation.cs
@@ -7,8 +7,6 @@
 
 using System;
 using System.Linq;
-using System.Runtime.Serialization;
-using System.Text;
 using System.Threading.Tasks;
 using Gauge.CSharp.Lib;
 using Gauge.CSharp.Lib.Attribute;
@@ -79,7 +77,8 @@ public void ReadTable(Table table)
         }
 
         [Step("Take Screenshot in reference DLL")]
-        public void TakeDllReferenceScreenshot() {
+        public void TakeDllReferenceScreenshot()
+        {
             GaugeScreenshots.RegisterCustomScreenshotWriter(new ReferenceDll.ScreenshotWriter());
             GaugeScreenshots.Capture();
             GaugeScreenshots.RegisterCustomScreenshotWriter(new StringScreenshotWriter());
@@ -91,11 +90,6 @@ public class CustomSerializableException : Exception
             public CustomSerializableException(string s) : base(s)
             {
             }
-
-            public CustomSerializableException(SerializationInfo info, StreamingContext context)
-                : base(info, context)
-            {
-            }
         }
 
         public class CustomException : Exception

diff --git a/_testdata/SampleDllReference/gauge_bin/FluentAssertions.Core.dll b/_testdata/SampleDllReference/gauge_bin/FluentAssertions.Core.dll
diff --git a/_testdata/SampleDllReference/gauge_bin/FluentAssertions.dll b/_testdata/SampleDllReference/gauge_bin/FluentAssertions.dll
diff --git a/_testdata/SampleDllReference/gauge_bin/Gauge.CSharp.Lib.dll b/_testdata/SampleDllReference/gauge_bin/Gauge.CSharp.Lib.dll
diff --git a/_testdata/SampleDllReference/gauge_bin/IntegrationTestSampleDllReference.deps.json b/_testdata/SampleDllReference/gauge_bin/IntegrationTestSampleDllReference.deps.json
@@ -8,18 +8,18 @@
     ".NETCoreApp,Version=v8.0": {
       "IntegrationTestSampleDllReference/1.0.0": {
         "dependencies": {
-          "Gauge.CSharp.Lib": "0.11.1",
+          "Gauge.CSharp.Lib": "0.12.0",
           "ReferenceDll": "1.0.0.0"
         },
         "runtime": {
           "IntegrationTestSampleDllReference.dll": {}
         }
       },
-      "Gauge.CSharp.Lib/0.11.1": {
+      "Gauge.CSharp.Lib/0.12.0": {
         "runtime": {
           "lib/net8.0/Gauge.CSharp.Lib.dll": {
-            "assemblyVersion": "0.11.1.0",
-            "fileVersion": "0.11.1.0"
+            "assemblyVersion": "0.12.0.0",
+            "fileVersion": "0.12.0.0"
           }
         }
       },
@@ -31,19 +31,27 @@
           }
         }
       },
-      "FluentAssertions/4.19.4.0": {
+      "FluentAssertions/6.12.2.0": {
         "runtime": {
           "FluentAssertions.dll": {
-            "assemblyVersion": "4.19.4.0",
-            "fileVersion": "4.19.4.0"
+            "assemblyVersion": "6.12.2.0",
+            "fileVersion": "6.12.2.0"
           }
         }
       },
-      "FluentAssertions.Core/4.19.4.0": {
+      "System.Configuration.ConfigurationManager/4.0.0.0": {
         "runtime": {
-          "FluentAssertions.Core.dll": {
-            "assemblyVersion": "4.19.4.0",
-            "fileVersion": "4.19.4.0"
+          "System.Configuration.ConfigurationManager.dll": {
+            "assemblyVersion": "4.0.0.0",
+            "fileVersion": "4.6.25519.3"
+          }
+        }
+      },
+      "System.Security.Cryptography.ProtectedData/4.0.2.0": {
+        "runtime": {
+          "System.Security.Cryptography.ProtectedData.dll": {
+            "assemblyVersion": "4.0.2.0",
+            "fileVersion": "4.6.25519.3"
           }
         }
       }
@@ -55,24 +63,29 @@
       "serviceable": false,
       "sha512": ""
     },
-    "Gauge.CSharp.Lib/0.11.1": {
+    "Gauge.CSharp.Lib/0.12.0": {
       "type": "package",
       "serviceable": true,
-      "sha512": "sha512-QEgfnNnhgPkW+BuXcz4bKN4DsjFWEepIN7gcIs68/STVlejB6LaMYDmrDFdakSVV6G21xWz4U8egSurZsN4RaA==",
-      "path": "gauge.csharp.lib/0.11.1",
-      "hashPath": "gauge.csharp.lib.0.11.1.nupkg.sha512"
+      "sha512": "sha512-C3bYsHzxJznZ9ZLIkiZ8SjoukTkIwG55Ra0Yo9uGl1ynyvHJeVPYQSLkAd6ogPqJl905BFSrQqt6uII0g4vU3g==",
+      "path": "gauge.csharp.lib/0.12.0",
+      "hashPath": "gauge.csharp.lib.0.12.0.nupkg.sha512"
     },
     "ReferenceDll/1.0.0.0": {
       "type": "reference",
       "serviceable": false,
       "sha512": ""
     },
-    "FluentAssertions/4.19.4.0": {
+    "FluentAssertions/6.12.2.0": {
+      "type": "reference",
+      "serviceable": false,
+      "sha512": ""
+    },
+    "System.Configuration.ConfigurationManager/4.0.0.0": {
       "type": "reference",
       "serviceable": false,
       "sha512": ""
     },
-    "FluentAssertions.Core/4.19.4.0": {
+    "System.Security.Cryptography.ProtectedData/4.0.2.0": {
       "type": "reference",
       "serviceable": false,
       "sha512": ""

diff --git a/_testdata/SampleDllReference/gauge_bin/IntegrationTestSampleDllReference.dll b/_testdata/SampleDllReference/gauge_bin/IntegrationTestSampleDllReference.dll
diff --git a/_testdata/SampleDllReference/gauge_bin/IntegrationTestSampleDllReference.pdb b/_testdata/SampleDllReference/gauge_bin/IntegrationTestSampleDllReference.pdb
diff --git a/_testdata/SampleDllReference/gauge_bin/ReferenceDll.dll b/_testdata/SampleDllReference/gauge_bin/ReferenceDll.dll
diff --git a/_testdata/SampleDllReference/gauge_bin/ReferenceDll.pdb b/_testdata/SampleDllReference/gauge_bin/ReferenceDll.pdb
diff --git a/_testdata/SampleDllReference/gauge_bin/System.Configuration.ConfigurationManager.dll b/_testdata/SampleDllReference/gauge_bin/System.Configuration.ConfigurationManager.dll
diff --git a/_testdata/SampleDllReference/gauge_bin/System.Security.Cryptography.ProtectedData.dll b/_testdata/SampleDllReference/gauge_bin/System.Security.Cryptography.ProtectedData.dll
diff --git a/_testdata/SampleDllReference/libs/FluentAssertions.Core.dll b/_testdata/SampleDllReference/libs/FluentAssertions.Core.dll
diff --git a/_testdata/SampleDllReference/libs/FluentAssertions.dll b/_testdata/SampleDllReference/libs/FluentAssertions.dll
diff --git a/_testdata/SampleDllReference/libs/Gauge.CSharp.Lib.dll b/_testdata/SampleDllReference/libs/Gauge.CSharp.Lib.dll