Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: basic onboarding flow #233

Merged
merged 12 commits into from
Jan 30, 2024
Merged

feat: basic onboarding flow #233

merged 12 commits into from
Jan 30, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Jan 24, 2024 •
edited
Loading

This PR adds:

  • welcome screen
  • set password screen
  • better redirects on all pages based on your current state (node setup? running? etc.)

TODO

  • unlock screen for the management UI - can be the same password (same as Voltage -> accessing e.g. thunderhub)
  • how does the user even download this app? (from getalby.com, the extension)
  • how does the user get liquidty?
  • start, then open in incognito tab, should need to enter password
  • auth
  • backup screen?
  • post-start & no connections - recommend connecting with Alby? (e.g. how to setup a lightning address?)
  • Rethink the navbar?
  • empty /apps state -> can we have a CTAs: (user currently has no balance, maybe no channels).
    • "Get your lightning address" -> goes to create an Alby account? and what permissions do you provide?
    • Connect to the Alby extension
    • Connect to a recommended Nostr app?
    • Problem: if you go directly to install this app, and then set it up and you can't use it without connecting an app, does that feel like bad UX? - it cannot be advertised as a "Wallet"? is it a signer?
  • Damus => nwc.getalby.com -> how does it get to the non-custodial version ??? do we need a mobile wallet (or scheme handler) that supports NWA? a new NIP-47 method for making new connection strings? 😁

rolznz and others added 12 commits January 24, 2024 21:54
@rolznz
feat: basic onboarding flow
e6f7f9e
@rolznz
fix: setup redirect
0d57bd4
@bumi
DO deploy cofig
e1d8dac
@bumi
correct branch
cfc05b1
@bumi
do
b4d409b
@rolznz
fix: breez payment type check
b2ce61c
@rolznz
fix: decode breez created at, expires at, description and description…
5af3fd5 
… hash
@rolznz
chore: remove TODO
ae2fcc9
@bumi @frnandu
Test fmar (#242)
2e7af2e 
* go 1.21.x

* don't use alpine

* don't copy

* go-version: 1.21.x

* don't run tests

* wget libbreez_sdk_bindings and copy it into final

* wails worflow

* wails worflow

* wails worflow

* wails worflow

* wails worflow

* wails worflow

* prepare:http

* remove alby-deployment stuff

* uncomment tests

* uncomment tests

* remove workflow, multiplatform only amd64 for now

* try building for arm64

* GOARCH=$(echo "$TARGETPLATFORM" | cut -d'/' -f2)

* update to github.com/breez/breez-sdk-go v0.2.14

* update to github.com/breez/breez-sdk-go v0.2.14

* add linux/386

* wails doctor

* wails doctor

---------

Co-authored-by: Fmar <frnandu@gmail.com>
@rolznz
fix: lnd address, improve error handling and logging
dfea114
@rolznz
Merge branch 'feat/onboarding-flow' of github.com:getAlby/nostr-walle…
f4f36b4 
…t-connect into feat/onboarding-flow
@rolznz
Merge remote-tracking branch 'origin/feat/wails-v2' into feat/onboard…
717f369 
…ing-flow
@rolznz rolznz marked this pull request as ready for review January 30, 2024 12:48
@rolznz rolznz merged commit 33ce4db into feat/wails-v2 Jan 30, 2024
2 checks passed
@bumi bumi deleted the feat/onboarding-flow branch May 6, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolznz @bumi