build specific api files #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on the build this copies the request api that will be used in the JS app
rolznz
reviewed
Jan 20, 2024
frontend/package.json
Outdated
| @@ -5,9 +5,11 @@ | |||
| "type": "module", | |||
| "scripts": { | |||
| "dev": "vite", | |||
| "dev:wails": "VITE_NWC_APP_TYPE=WAILS vite", | |||
| "dev:wails": "yarn prepare:wails && VITE_NWC_APP_TYPE=WAILS vite", | |||
There was a problem hiding this comment.
VITE_NWC_APP_TYPE should not be needed now, right?
Should we delete the original request.ts file and add it to .gitignore?
There was a problem hiding this comment.
if you think that's a doable way, we can go forward with that.
|
Downsides of this approach:
But we probably will not make many more edits to this file. The alternative would be a dynamic import using the value of an env variable (that was removed in this PR) as part of the filename of the imported file, which would not have the downsides mentioned above. I will merge this for now, in the rare case that we end up adding more platform-specific code we could revisit it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on the build this copies the request api that will be used in the JS app