-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add manual migrations using gormigration #148
Conversation
- initial migration (postgres and sqlite) - update preimage to be NULL instead of '' - add composite index for summing payments in budget period also fixes preimage to be NULL by default and removes gorm model hints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to test it locally, but looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some pieces could be a bit more idiomatic.
@kiwiidb all feedback has been addressed. Thanks! |
@bumi did you test it locally? |
I have, in all the scenario's that you also mentioned. |
yep, I did and looks good to me. |
also fixes preimage to be NULL by default and removes gorm model hints
Manually tested with:
Notes: