fix: use budget to calculate balance if set #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiwiidb
reviewed
Aug 31, 2023
There was a problem hiding this comment.
I don't feel like this would be a good change. I don't know if there are users who asked for this but personally I would like to see my full balance in Amethyst/Damus, regardless if I would have set a budget. Because I would like to see how much sats I've earned with zaps in total and it would be practical. So I feel it's better to return the current budget usage instead of changing the balance field to have a different meaning based on if there is a budget set or not. Then clients can choose what to display.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes unused fields from response