Update to LDK 0.4.2 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix inbound capacity comment
We add a `Node::start_with_runtime` method that allows to reuse a pre-existing runtime, e.g., to avoid stacking runtime contexts when running in a tokio async environment.
This reverts commit 0285b55.
…-uniffi-target-folder Ignore all `target` folders including bindings
…tart-with-runtime Allow start from outer runtime
This reverts commit abfcc2e.
Revert "Pin `cc` to `1.0.105` for MSRV"
* Add `UnifiedQrPayment` module for BIP21 URIs
Firstly, I thought I staged and made commits for `unified_qr.rs`
so sorry if this is out of order!
But in `unified_qr.rs` I
- I introduced the `UnifiedQrPayment` struct to handle creating
and paying BIP21 URIs
- `receive` generates a URI with an on-chain address and BOLT11
invoice and returns the URI as a string
- `send` will parse a given URI string and attempt to send the
BOLT12 offer, BOLT11 invoice, then if those fail the fallback
on-chain address will be paid to.
- Then I included tests for URI generation and URI parsing
- Also has logging and error handling for payment operations
* Add `unified_qr_payment` payment handler to `Node`
- implement unified_qr_payment method to create the
Unified QR payment handler
- Includes conditional UniFFI features and updates docs
with BIP21 and BOLT11 links
* Add support for `unified_qr` in payment mod
- Included unified_qr in payment module
- Added `PaymentResult` and `UnifiedQrPayment`
from unified_qr for public use
* Add bip21 crate to handle BIP21 URIs
* Add `UnifiedQrPayment` and `PaymentResult` to `ldk_node.udl`
- Introduced `UnifiedQrPayment` method to `Node` interface
- Add `UnifiedQrPayment` interface with `receieve and
`send` methods
- Add `PaymentResult` interface (enum) with `Onchain`,
`Bolt11` and `Bolt12` fields
These changes add support for our UniFFI bindings and enable
the use of `unified_qr_payment` payment handler in Swift,
and Kotlin.
* Update `Error` enum with URI related errors
- Add `UriParameterFailed` and `InvalidUri` fields to
the `Error` enum
- Added related error messages in the Display impl for
the new fields
* Add `PaymentResult` import for UniFFI bindings
- Added `PaymentResult` so the .udl could access
the enum
- Added comment to explain the need to import any
re-exported items to enure they're accessible in
UniFFI. (becasue rustc says to add them in `lib.rs`
* Add Unified QR `send`/`receive` integration tests
- Added `unified_qr_send_receive` test to verify the `UnifedQrPayment`
functionality
- Added logic to handle paying a `BOLT12` offer, `BOLT11` invoice,
and if those fail `On-chain` tx from a URI.
- Validated each payments successful event
- Ensured the off-chain and on-chain balacnes reflected the payment
attempts
* Update PR with optimizations and nit fixups
The changes include:
- Fixed a handful of nits for better readability in
docs and simple grammar errors and made various name
changes that affected the committed files.
- Added a helper function in unified_qr.rs called
capitalize_qr_params to format the lightning param in
the receive method
- Removed the optional message in the receive method and
made it a required &str
- Adjusted UDL formatting to use tabs instead of spaces
These changes were made to improve code quality and
maintainability based on the review feedback
* Refactor URI parsing and add Bolt12 offer in receive
Changes include:
- Modified serialize_params to serialize both invoices and offers
- Refactored deserialize_temp by removing the code that was
parsing based on the lightning invoice/offer prefix. I instead
used for loop to iterate over each lightning parameter,
attempting to parse the string as an offer first, and then as an
invoice. May need to log an error if neither succeeds
- Added support for Bolt12 offers in the receive method
- Updated capitalize_params function to handle multiple lightning
parameters
- Added a generate_bip21_uri test to show what the uri looks
like in integration_tests_rust
- Adjusted integration tests. Still needs work
Still trying to figure out a bug related to Bolt12 offers being
"paid" when it should fall back to an on-chain tx
* Update BOLT12 offer to use `lno` key
In this commit:
- In serialize_params, BOLT12 offers were changed
to be serialized with the `lno` key rather than
the `lightning` key
- During deserializing, I had to make the same update.
Used a match to check whether it was a `lightning`
or `lno` key and then parsed accordingly.
- Next, a small name change: capitalize_qr_params to
format_uri. Previously I changed the value after
"&lightning" to all caps, but the "&lno=" value
wasn't being changed. So, added a helper method inside
format_uri to capitalize the values given the key!
- Updated corresponding tests with `lno` update
Small nits:
- Updated QrPaymentResult with more thorough docs
- Added a parsing test with an offer
* Refactor for clarity and improve error handling
This commit fixes a handful of minor comments/nits
that include:
- Updates to set the `bip21` crates default-features to false,
to minimize dependencies.
- Enable the `std` feature since we use/benefit from it.
- In `receive` return `InvoiceCreationFailed` or `OfferCreationFailed`
when creating an invoice or offer. Rather than silently logging the
error.
- Also in `receive` we first check if an amount is specified, and if
not, return an error and abort.
- Pass in `Config` to `UnifiedQrPayment` struct to use the users config
network.
- In `send` instead of checking each network for the `NetworkChecked`
URI, we pass in the `Config::Network`.
- Simplifed param parsing in `deserialize_temp` by directly finding
the key and parsing the corresponding value.
- General documentation fixes.
- In parsing tests, moved longer invoice/offer strings into.
variables that start with expected_ for clarity.
* Fix docs for clarity
Cleaned up the docs so they are easier to understand for the
user. Also changed the message param in receive to description.
.. rather than once per target.
Recently, Rust 1.80 introduced automatic checking of `cfg` flags (see https://blog.rust-lang.org/2024/05/06/check-cfg.html). Here, we add all custom `cfg`s to the expected list
…-check-cfg Account for `check-cfg`
…-payment-variable-naming-bindings
…-test-cfg Fix: added `cfg(cln_test)` to `Cargo.toml`
Pin `tokio` to v1.38.1 to fix MSRV build
…oads Enable caching for `bitcoind`/`electrs` in CI
.. just to be sure.
…os-specific Make cache `key`s OS-specific
... see if dropping $HOME works.
…hing Try fix caching
.. since it stopped working now?
This was referenced Oct 22, 2024
|
Run VSS server locally:
cd java
Rebuild:
View the database:
|
…s-program-len Fix invalid witness program length
We previously erroneously included the version byte trying to construct a `WitnessProgram`, which was was recently fixed. Here we add some more comments to the code explaining what went wrong, and also add a debug assertion checking `list_unspent_utxos` retrieves at least one `Utxo` when we see any confirmed balances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52
NOTES:
ldk_node_data.sqlite.TODOs: