Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: get encoded channel monitors #49

Merged
merged 7 commits into from
Sep 24, 2024
Merged

feat: get encoded channel monitors #49

merged 7 commits into from
Sep 24, 2024

Conversation

rolznz
Copy link

@rolznz rolznz commented Sep 23, 2024 •
edited
Loading

TODOs:

  • error handling - function should return an error instead of using empty arrays
  • review naming
  • for some reason tests are failing

@rolznz rolznz requested review from bumi and rdmitr September 23, 2024 10:15
rdmitr
rdmitr reviewed Sep 23, 2024
View reviewed changes
src/lib.rs Show resolved Hide resolved
rdmitr
rdmitr approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@rdmitr rdmitr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with one minor comment :)

@rolznz
Copy link
Author

rolznz commented Sep 24, 2024

Added ability to restore monitors and force close channels

@rolznz rolznz merged commit 62cad89 into main Sep 24, 2024
2 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdmitr rdmitr rdmitr approved these changes

@bumi bumi Awaiting requested review from bumi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolznz @rdmitr