Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update libproj to 9.0.0 #118

Merged
merged 3 commits into from
Mar 21, 2022
Merged

update libproj to 9.0.0 #118

merged 3 commits into from
Mar 21, 2022

Conversation

michaelkirk
Copy link
Member

- container:
image: georust/proj-ci:rust-1.53
image: georust/proj-ci:proj-9.0.0-rust-1.52
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still waffling on if it's better to have explicit immutablish docker tags, or if it's better to treat tags like release branches and just clobber it knowing that it (should be) backwards compatible. 🤷

env:
_PROJ_SYS_TEST_EXPECT_BUILD_FROM_SRC: 0
features: ""
- container:
image: georust/proj-ci:rust-1.52
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that this diff is confusing. It might be helpful to review the commits individually. The first commit updates the CI containers without updating proj, just to be sure we're using recent rust.

It also re-orders the tasks in a way that I think makes the test matrix more clear.

The remaining two commits actually update to proj-9.0.0

@michaelkirk
Copy link
Member Author

whoop. Closing while I fix CI.

@michaelkirk michaelkirk reopened this Mar 16, 2022
@michaelkirk
Copy link
Member Author

A bug in my build script caused me to fail to push up all the expected docker container versions. Should be fixed now.

(also rebased against main)

@michaelkirk michaelkirk mentioned this pull request Mar 16, 2022
@michaelkirk michaelkirk marked this pull request as ready for review March 21, 2022 18:28
@urschrei
Copy link
Member

\o/

@michaelkirk
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 21, 2022

Build succeeded:

@bors bors bot merged commit d5db749 into main Mar 21, 2022
@michaelkirk michaelkirk deleted the mkirk/proj-9.0.0 branch April 11, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update bundled proj to 9.0.0
3 participants