-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update libproj to 9.0.0 #118
Conversation
michaelkirk
commented
Mar 16, 2022
- Fixes update bundled proj to 9.0.0 #96
- supersedes upgrade to proj 8.2 #97
- container: | ||
image: georust/proj-ci:rust-1.53 | ||
image: georust/proj-ci:proj-9.0.0-rust-1.52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still waffling on if it's better to have explicit immutablish docker tags, or if it's better to treat tags like release branches and just clobber it knowing that it (should be) backwards compatible. 🤷
env: | ||
_PROJ_SYS_TEST_EXPECT_BUILD_FROM_SRC: 0 | ||
features: "" | ||
- container: | ||
image: georust/proj-ci:rust-1.52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that this diff is confusing. It might be helpful to review the commits individually. The first commit updates the CI containers without updating proj, just to be sure we're using recent rust.
It also re-orders the tasks in a way that I think makes the test matrix more clear.
The remaining two commits actually update to proj-9.0.0
whoop. Closing while I fix CI. |
18f879f
to
24f2396
Compare
A bug in my build script caused me to fail to push up all the expected docker container versions. Should be fixed now. (also rebased against main) |
\o/ |
bors r+ |
Build succeeded: |