Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Autocomplete Dropdown not closing correctly on click #576

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Fix: Autocomplete Dropdown not closing correctly on click #576

merged 2 commits into from
Aug 14, 2023

Conversation

Angi-Kinas
Copy link
Collaborator

  • Makes sure that the click event is being dispatched to the document
  • Adds documentation for it

@Angi-Kinas Angi-Kinas changed the title Fix: Autocomplete Dropdown not closing on click on record Fix: Autocomplete Dropdown not closing correctly on click Aug 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023 •
edited
Loading

Affected libs: ui-inputs, feature-dataviz, feature-record, feature-router, feature-editor, feature-search, feature-map, ui-elements, feature-catalog, ui-catalog, ui-search, util-shared, feature-auth, ui-widgets, ui-map,
Affected apps: metadata-converter, metadata-editor, datahub, demo, webcomponents, search, datafeeder, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Aug 14, 2023 •
edited
Loading

Coverage Status

coverage: 83.188% (-0.5%) from 83.694% when pulling 5d7ba51 on fix-close-dropdown into 260378e on main.

jahow
jahow approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, and bonus points for the doc 😉

libs/util/shared/src/lib/utils/event.spec.ts Outdated Show resolved Hide resolved
libs/util/shared/src/lib/utils/event.spec.ts Outdated Show resolved Hide resolved
@Angi-Kinas Angi-Kinas merged commit be8139d into main Aug 14, 2023
@Angi-Kinas Angi-Kinas deleted the fix-close-dropdown branch August 14, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahow jahow jahow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Angi-Kinas @coveralls @jahow