Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL/tiles distinction and PM Tiles support #91

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Aug 6, 2024

This PR adds a distinction between URLs and Tiles when adding and updating sources in MapLibre. Basically it checks the URL passed from the creation form, and if the URL is tile based it'll create the source with the tiles attribute, otherwise it will use the url attribute.

This also adds support for PM Tiles protocol.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/pm_tiles

@gjmooney gjmooney added the enhancement New feature or request label Aug 6, 2024
@martinRenou martinRenou changed the title Add URL/tiles distinctiond and PM Tiles support Add URL/tiles distinction and PM Tiles support Aug 20, 2024
@martinRenou
Copy link
Member

martinRenou commented Aug 20, 2024

please update snapshots!!

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit e3e4857 into geojupyter:main Aug 20, 2024
This was referenced Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants