Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework tests #73

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Rework tests #73

merged 1 commit into from
Jul 25, 2024

Conversation

gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Jul 25, 2024 •
edited
Loading

Removes some screenshot comparisons and uses a test.jgis file from the tests directory instead of the one in the example directory.

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/remove_screenshots

@gjmooney gjmooney marked this pull request as ready for review July 25, 2024 11:46
martinRenou
martinRenou approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit f866ea3 into geojupyter:main Jul 25, 2024
10 checks passed
@brichet brichet mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjmooney @martinRenou