Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undo bug #57

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Fix undo bug #57

merged 2 commits into from
Jul 18, 2024

Conversation

gjmooney
Copy link
Collaborator

Fix bug where undo action did not restore the layer on the map.

@gjmooney gjmooney added the bug Something isn't working label Jul 17, 2024
Copy link
Contributor

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/undo_bug

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm it fixes the issue (see screencast below). Although I'm really confused as to why?

Screencast.from.2024-07-17.16-37-02.mp4

@martinRenou
Copy link
Member

I see the visual regression tests are not passing so it's probably breaking something else. Which makes me think it would be great to have some visual regression tests on the context menus.

@martinRenou
Copy link
Member

martinRenou commented Jul 18, 2024

please update snapshots

@martinRenou
Copy link
Member

Looks like the bot does not spawn.

As discussed privately, the galata tests failure is not related to this PR. Let's merge and debug the CI separately

@martinRenou martinRenou merged commit 787afbe into geojupyter:main Jul 18, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants