Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Context menu to layer tree items #48

Merged
merged 16 commits into from
Jul 17, 2024

Conversation

gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Jul 12, 2024

Add context menu to layer tree items

  • Remove layer
  • Rename layer
  • Remove group
  • Rename group
  • Add selected layers to group (Will need to be able to select multiple items for this)
  • Make the input boxes when renaming look nicer

context_menu_2

Copy link
Contributor

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/context_menu

@gjmooney gjmooney added the enhancement New feature or request label Jul 12, 2024
@gjmooney gjmooney force-pushed the context_menu branch 2 times, most recently from aa2020c to 3aa43b7 Compare July 16, 2024 11:38
@gjmooney gjmooney marked this pull request as ready for review July 16, 2024 14:06
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just have tiny comments otherwise it looks great

packages/base/src/commands.ts Outdated Show resolved Hide resolved
@@ -106,6 +115,68 @@ export function addCommands(
)
});

commands.addCommand(CommandIDs.removeLayer, {
label: trans.__('Remove Layer'),
execute: () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add a keyboard shortcut here for delete

Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gjmooney, this is great.

I have some suggestions below.

packages/base/src/commands.ts Show resolved Hide resolved
python/jupytergis_lab/src/index.ts Show resolved Hide resolved
@brichet
Copy link
Collaborator

brichet commented Jul 16, 2024

I don't know if this is related to this PR, but it seems that removing a group does not affect the file on disk.

@brichet
Copy link
Collaborator

brichet commented Jul 17, 2024

I don't know if this is related to this PR, but it seems that removing a group does not affect the file on disk.

It should be fixed on main, it was not related to these changes.

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@martinRenou martinRenou merged commit d98aa7d into geojupyter:main Jul 17, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants