Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a min-height to the toolbar separator #200

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Add a min-height to the toolbar separator #200

merged 1 commit into from
Nov 8, 2024

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Nov 8, 2024

This PR fix the toolbar separator not displayed in the popup toolbar.

Related to jupyterlab/jupyterlab#16884

image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Binder 👈 Launch a Binder on branch brichet/jupytergis/fix-toolbar-separator

@brichet brichet added the bug Something isn't working label Nov 8, 2024
@martinRenou
Copy link
Member

Ah thanks! I'm surprised this is a fix for JupyterGIS, I thought we were only reusing the JupyterLab toolbar.

Do you think we should port that change to JupyterCAD too or there could be some shared CSS?

@brichet
Copy link
Collaborator Author

brichet commented Nov 8, 2024 •
edited
Loading

Ah thanks! I'm surprised this is a fix for JupyterGIS, I thought we were only reusing the JupyterLab toolbar.

You'll have more details here jupyterlab/jupyterlab#16884 (comment)

Do you think we should port that change to JupyterCAD too

I ported it to JupyterCAD too jupytercad/JupyterCAD#577

or there could be some shared CSS?

Don't know how but t could be nice, I think that we are sharing several components

@martinRenou
Copy link
Member

Ok! Thanks

@martinRenou martinRenou merged commit b18b9fb into geojupyter:main Nov 8, 2024
10 of 11 checks passed
@brichet brichet deleted the fix-toolbar-separator branch November 8, 2024 13:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Integration tests repot: appsharing.space

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Preview PR at appsharing.space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brichet @martinRenou