Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first draft of documentation for JupyterGIS #195

Merged
merged 2 commits into from
Nov 5, 2024
Merged

first draft of documentation for JupyterGIS #195

merged 2 commits into from
Nov 5, 2024

Conversation

annefou
Copy link
Contributor

@annefou annefou commented Oct 25, 2024

based on JupyterCAD documentation

@annefou
first draft of documentation for JupyterGIS
97b2104 
based on JupyterCAD documentation
@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch annefou/jupytergis/doc

@gjmooney gjmooney added the documentation Improvements or additions to documentation label Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

Preview PR at appsharing.space

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

Integration tests repot: appsharing.space

martinRenou
martinRenou reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just have a tiny suggestion otherwise it looks good!

I will setup readthedocs properly for the repo so we can see a preview once this is merged.

docs/source/contributing.rst Outdated Show resolved Hide resolved
@brichet
Copy link
Collaborator

brichet commented Nov 4, 2024 •
edited
Loading

Thanks @annefou
Do we already have a jupyterGIS project in readthedocs ?
Should we include a .readthedocs.yaml file to update it automatically ?

Maybe we can do it in a follow up PR.

@martinRenou
Copy link
Member

I just created the project on readthedocs https://readthedocs.org/projects/jupytergis

@annefou @martinRenou
Update docs/source/contributing.rst
dc2169e 
Co-authored-by: martinRenou <martin.renou@gmail.com>
martinRenou
martinRenou approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's get this in and we can finalize the readthedocs setup separately

@martinRenou martinRenou merged commit 6ecdd6f into geojupyter:main Nov 5, 2024
8 of 9 checks passed
@annefou annefou deleted the doc branch November 5, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annefou @brichet @martinRenou @gjmooney