-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting #15
Merged
Merged
Linting #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I run $ git status
Your branch is up-to-date with 'martinRenou/linting'.
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: .github/workflows/build.yml
modified: .github/workflows/check-release.yml
modified: .github/workflows/prep-release.yml
modified: .github/workflows/publish-release.yml
modified: packages/base/src/commands.ts
modified: packages/base/src/formdialog.tsx
modified: packages/base/src/mainview/mainview.tsx
modified: packages/base/src/mainview/mainviewmodel.ts
modified: packages/base/src/panelview/formbuilder.tsx
modified: packages/base/src/panelview/header.tsx
modified: packages/base/src/panelview/model.ts
modified: packages/base/src/panelview/objectproperties.tsx
modified: packages/base/src/panelview/rightpanel.tsx
modified: packages/base/src/toolbar/usertoolbaritem.tsx
modified: packages/base/src/toolbar/widget.tsx
modified: packages/base/src/tools.ts
modified: packages/base/src/types.ts
modified: packages/base/src/widget.tsx
modified: packages/schema/src/doc.ts
modified: packages/schema/src/interfaces.ts
modified: packages/schema/src/model.ts
modified: packages/schema/src/token.ts
modified: python/jupytergis_core/src/externalcommand.ts
modified: python/jupytergis_core/src/factory.ts
modified: python/jupytergis_core/src/index.ts
modified: python/jupytergis_core/src/jgisplugin/modelfactory.ts
modified: python/jupytergis_core/src/jgisplugin/plugins.ts
modified: python/jupytergis_core/src/plugin.ts
modified: python/jupytergis_core/style/index.css
modified: python/jupytergis_lab/src/index.ts
modified: python/jupytergis_lab/src/notebookrenderer.ts
modified: python/jupytergis_lab/style/base.css
modified: python/jupytergis_lab/style/index.css
modified: ui-tests/tests/notebook.spec.ts
modified: ui-tests/tests/ui.spec.ts Looks like you should run it again |
Indeed! Thanks for trying. Not sure what was going wrong, but starting again from scratch I could see the same as you/ |
brichet
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @martinRenou
gjmooney
pushed a commit
to martinRenou/jupytergis
that referenced
this pull request
Jun 25, 2024
* Run linters * Add lint check * More linting * Iterate * Missing config files * Update packages * Separate commands * Linting again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.