Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting #15

Merged
merged 8 commits into from
Jun 20, 2024
Merged

Linting #15

merged 8 commits into from
Jun 20, 2024

Conversation

martinRenou
Copy link
Member

No description provided.

Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupytergis/linting

@brichet
Copy link
Collaborator

brichet commented Jun 20, 2024

If I run jlpm lint on your branch I have

$ git status
Your branch is up-to-date with 'martinRenou/linting'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   .github/workflows/build.yml
	modified:   .github/workflows/check-release.yml
	modified:   .github/workflows/prep-release.yml
	modified:   .github/workflows/publish-release.yml
	modified:   packages/base/src/commands.ts
	modified:   packages/base/src/formdialog.tsx
	modified:   packages/base/src/mainview/mainview.tsx
	modified:   packages/base/src/mainview/mainviewmodel.ts
	modified:   packages/base/src/panelview/formbuilder.tsx
	modified:   packages/base/src/panelview/header.tsx
	modified:   packages/base/src/panelview/model.ts
	modified:   packages/base/src/panelview/objectproperties.tsx
	modified:   packages/base/src/panelview/rightpanel.tsx
	modified:   packages/base/src/toolbar/usertoolbaritem.tsx
	modified:   packages/base/src/toolbar/widget.tsx
	modified:   packages/base/src/tools.ts
	modified:   packages/base/src/types.ts
	modified:   packages/base/src/widget.tsx
	modified:   packages/schema/src/doc.ts
	modified:   packages/schema/src/interfaces.ts
	modified:   packages/schema/src/model.ts
	modified:   packages/schema/src/token.ts
	modified:   python/jupytergis_core/src/externalcommand.ts
	modified:   python/jupytergis_core/src/factory.ts
	modified:   python/jupytergis_core/src/index.ts
	modified:   python/jupytergis_core/src/jgisplugin/modelfactory.ts
	modified:   python/jupytergis_core/src/jgisplugin/plugins.ts
	modified:   python/jupytergis_core/src/plugin.ts
	modified:   python/jupytergis_core/style/index.css
	modified:   python/jupytergis_lab/src/index.ts
	modified:   python/jupytergis_lab/src/notebookrenderer.ts
	modified:   python/jupytergis_lab/style/base.css
	modified:   python/jupytergis_lab/style/index.css
	modified:   ui-tests/tests/notebook.spec.ts
	modified:   ui-tests/tests/ui.spec.ts

Looks like you should run it again

@martinRenou
Copy link
Member Author

Indeed! Thanks for trying. Not sure what was going wrong, but starting again from scratch I could see the same as you/

@martinRenou martinRenou marked this pull request as ready for review June 20, 2024 15:37
@martinRenou martinRenou requested a review from brichet June 20, 2024 15:37
Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martinRenou

@brichet brichet merged commit 39c4b38 into geojupyter:main Jun 20, 2024
9 checks passed
@martinRenou martinRenou deleted the linting branch June 20, 2024 17:14
gjmooney pushed a commit to martinRenou/jupytergis that referenced this pull request Jun 25, 2024
* Run linters

* Add lint check

* More linting

* Iterate

* Missing config files

* Update packages

* Separate commands

* Linting again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants