feat: Add CRA Generator #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doowb
requested changes
Jan 13, 2020
generator.js
Outdated
| // return if the generator is already registered | ||
| if (!isValid(app, 'generate-react')) return; | ||
|
|
||
| app.use(require('generate-project')); | ||
| app.register( |
There was a problem hiding this comment.
Please keep arguments on the same line when calling functions like this.
lib/constants.js
Outdated
| @@ -0,0 +1,17 @@ | |||
| module.exports = { | |||
| YARN: "yarn", | |||
There was a problem hiding this comment.
Please use single quotes in JavaScript files.
lib/generators/create-react-app.js
Outdated
| @@ -0,0 +1,45 @@ | |||
| const spawn = require("../spawn"); | |||
There was a problem hiding this comment.
Please use single quotes in JavaScript files. I think all of the uses in here should be single quotes.
package.json
Outdated
| "is-valid-app": "^0.3.0" | ||
| "is-valid-app": "^0.3.0", | ||
| "enquirer": "^2.3.2", | ||
| "generate": "^0.14.0", |
There was a problem hiding this comment.
I don't think that generate should be a dependency. I think it can be a devDependency.
|
Fixed everything as per your suggestion. Please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Adds a CRA generator.
Fixes #3
Type of change
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist