Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matchers to enable lte-defined Elm versions #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

knuton
Copy link

@knuton knuton commented Jan 8, 2018

I ran into a problem when adding a dependency to tesk9/accessible-html, v3.1.0:

Solving dependencies...
  ▶ No solution found: Unable to satisfy the following requirements:

- `tesk9/accessible-html (< 4.0.0)` required by `user-specified dependency`
- `tesk9/accessible-html (>= 3.1.0)` required by `user-specified dependency`

The code to determine the Elm version of a package assumes that the version constraint is always of the shape a.b.c <= v < x.y.z, but accessible-html specifies the Elm version in different way: https://github.com/tesk9/accessible-html/blob/3.1.0/elm-package.json#L23

This is a hot fix that extends the existing hack.

Ideas for a proper solution

The nice solution would be to resolve the Elm version constraints of the packages for compatibility. As far as I can see the Solve library does not offer that option.

How about adding the required Elm versions to the constraint set and adding an auto-detected (but configurable) Elm version to the graph?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant