avoid superfluous copy of data #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change avoids a copy of data. When parsing a strava export containing 1100 fit.gz activities, the parsing time goes down from 22 seconds to 13 seconds with that change.
|
I let the tests run and they seemed to have passed. We will look into this improvement and run speed tests of our own. These changes would be made in our internal repository, then later be pushed to this GitHub repository when we do another release of the SDK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change avoids a copy of data. When parsing a strava export containing 1100 fit.gz activities, the parsing time goes down from 22 seconds to 13 seconds with that change.