Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated configmap mountpoints based on ETCD replicas. #314

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Updated configmap mountpoints based on ETCD replicas. #314

merged 1 commit into from
Mar 30, 2022

Conversation

abdasgupta
Copy link
Contributor

@abdasgupta abdasgupta commented Mar 30, 2022 •
edited
Loading

How to categorize this PR?

/area TODO
/kind TODO

What this PR does / why we need it:
This PR is rework of #193.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

- If Spec.Replicas in ETCD CR is greater than 0 and a even number, then no statefulset for ETCD nodes will be created and so the ETCD cluster won't be setup by Druid

- Deployed configmap programmatically as component instead of chart
- configmap configures ETCD config based on the number of nodes in cluster. Number of nodes in cluster is derived from spec.Replicas of ETCD CR
- Introduced separate TLS config for client and peer communication with ETCD cluster

@abdasgupta abdasgupta requested a review from a team as a code owner March 30, 2022 11:40
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 30, 2022
@aaronfern aaronfern self-assigned this Mar 30, 2022
aaronfern
aaronfern requested changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove charts/etcd/templates/etcd-configmap.yaml as it's not required anymore

config/rbac/leader_election_role.yaml Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Mar 30, 2022
@ishan16696 ishan16696 mentioned this pull request Mar 30, 2022
Merged
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Mar 30, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 30, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 30, 2022
@gardener-robot
Copy link

@abdasgupta Labels area/todo, kind/todo do not exist.

1 similar comment
@gardener-robot
Copy link

@abdasgupta Labels area/todo, kind/todo do not exist.

aaronfern
aaronfern approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/second-opinion Needs second review by someone else labels Mar 30, 2022
@abdasgupta abdasgupta merged commit d204052 into gardener:master Mar 30, 2022
@abdasgupta abdasgupta deleted the rework branch March 30, 2022 17:58
@gardener-robot
Copy link

@abdasgupta Labels area/todo, kind/todo do not exist.

@ishan16696 ishan16696 mentioned this pull request Apr 5, 2022
Closed
@ashwani2k ashwani2k mentioned this pull request Jul 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfern aaronfern aaronfern approved these changes

Assignees

@aaronfern aaronfern

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abdasgupta @gardener-robot @aaronfern @gardener-robot-ci-1 @gardener-robot-ci-2