Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several improvements for compaction feature #258

Merged
merged 7 commits into from
Nov 16, 2021
Merged

Several improvements for compaction feature #258

merged 7 commits into from
Nov 16, 2021

Commits on Nov 15, 2021

  1. Add snapshot-lease flags for etcd-backup-restore

    @timuthy
    timuthy committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    ff0bb69 View commit details
    Browse the repository at this point in the history

  2. Change ServiceAccount, Role, RoleBinding names 

    The chosen names are a closer match to names that are already used
in the Gardener space.
    @timuthy
    timuthy committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    9f11f45 View commit details
    Browse the repository at this point in the history

  3. Don't set inital values for Lease spec 

    We don't want to set initial values for full/delta Lease objects because
the etcd-backup-restore sidecar is suppossed to set the corresponding values.
It's the only component which determins the full- and delta-snapshot
revisions. If we set initial values (`0`) then the controller might
create unexpected compaction jobs.
    @timuthy
    timuthy committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    f9c8718 View commit details
    Browse the repository at this point in the history

  4. Only reconcile leases if store is configured

    @timuthy
    timuthy committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    df61842 View commit details
    Browse the repository at this point in the history

  5. Add nil case to lease event handler

    @timuthy
    timuthy committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    8734edf View commit details
    Browse the repository at this point in the history

  6. Add enable-backup-compaction flag

    @timuthy
    timuthy committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    4141b63 View commit details
    Browse the repository at this point in the history

  7. Enhance documentation

    @timuthy
    timuthy committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    b3f7428 View commit details
    Browse the repository at this point in the history