[Security Hardened Kubernetes Cluster] Rule 2001 implementation #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
13 tasks
dimityrmirchev
requested changes
Nov 25, 2024
|
|
||
| > [!WARNING] | ||
| > `securityContext.allowPrivilegeEscalation` is set to `true` in the following exceptions: | ||
| > - container is running as `privileged` | ||
| > - `CAP_SYS_ADMIN` is added to the container | ||
| > - `CAP_SYS_ADMIN/SYS_ADMIN` is added to the container. More information can be found [here](https://github.com/kubernetes/kubernetes/issues/119568). |
There was a problem hiding this comment.
Suggested change
| > - `CAP_SYS_ADMIN/SYS_ADMIN` is added to the container. More information can be found [here](https://github.com/kubernetes/kubernetes/issues/119568). | |
| > - `CAP_SYS_ADMIN` or `SYS_ADMIN` is added to the container. More information can be found in [this issue](https://github.com/kubernetes/kubernetes/issues/119568). |
| var ( | ||
| checkResults []rule.CheckResult | ||
| allowsPrivilegeEscalation = func(securityContext corev1.SecurityContext) bool { | ||
| var addsCapSysAdmin = false |
There was a problem hiding this comment.
Suggested change
| var addsCapSysAdmin = false | |
| addsCapSysAdmin := false |
Comment on lines
83
to
85
| return securityContext.AllowPrivilegeEscalation == nil || *securityContext.AllowPrivilegeEscalation || | ||
| (securityContext.Privileged != nil && *securityContext.Privileged) || | ||
| addsCapSysAdmin |
There was a problem hiding this comment.
This reads better IMO.
Suggested change
| return securityContext.AllowPrivilegeEscalation == nil || *securityContext.AllowPrivilegeEscalation || | |
| (securityContext.Privileged != nil && *securityContext.Privileged) || | |
| addsCapSysAdmin | |
| var ( | |
| allowsPrivilegeEscalation = securityContext.AllowPrivilegeEscalation == nil || *securityContext.AllowPrivilegeEscalation | |
| hasPrivilegedContext = securityContext.Privileged != nil && *securityContext.Privileged | |
| ) | |
| return allowsPrivilegeEscalation || hasPrivilegedContext || addsCapSysAdmin |
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #356
Special notes for your reviewer:
Release note: