Add Security Hardened Kubernetes Cluster ruleset to managedk8s provider #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
13 tasks
gardener-robot-ci-2
added
the
reviewed/ok-to-test
AleksandarSavchev
changed the title
Security Hardened Kubernetes Cluster ruleset to managedk8s provider
gardener-robot-ci-2
added
needs/ok-to-test
dimityrmirchev
requested changes
Nov 15, 2024
docs/providers/managedk8s.md
Outdated
| @@ -10,6 +10,8 @@ The `Managed Kubernetes` provider implements the following `rulesets`: | |||
| - [DISA Kubernetes Security Technical Implementation Guide](../rulesets/disa-k8s-stig/ruleset.md) | |||
| - v2r1 | |||
| - v1r11 | |||
| - [Security Hardened Shoot Cluster](../rulesets/security-hardened-k8s-cluster/ruleset.md) | |||
There was a problem hiding this comment.
Suggested change
| - [Security Hardened Shoot Cluster](../rulesets/security-hardened-k8s-cluster/ruleset.md) | |
| - [Security Hardened Kubernetes Cluster](../rulesets/security-hardened-k8s-cluster/ruleset.md) |
example/config/managedk8s.yaml
Outdated
| @@ -170,6 +170,14 @@ providers: # contains information about known providers | |||
| # foo: bar | |||
| # nodeGroupByLabels: | |||
| # - foo | |||
| - id: security-hardened-k8s-cluster | |||
There was a problem hiding this comment.
Suggested change
| - id: security-hardened-k8s-cluster | |
| - id: security-hardened-k8s |
pkg/provider/builder/managedk8s.go
Outdated
| @@ -12,6 +12,7 @@ import ( | |||
| "github.com/gardener/diki/pkg/provider" | |||
| "github.com/gardener/diki/pkg/provider/managedk8s" | |||
| "github.com/gardener/diki/pkg/provider/managedk8s/ruleset/disak8sstig" | |||
| "github.com/gardener/diki/pkg/provider/managedk8s/ruleset/securityhardenedcluster" | |||
There was a problem hiding this comment.
Suggested change
| "github.com/gardener/diki/pkg/provider/managedk8s/ruleset/securityhardenedcluster" | |
| "github.com/gardener/diki/pkg/provider/managedk8s/ruleset/securityhardenedk8s" |
|
|
||
| const ( | ||
| // RulesetID is a constant containing the id of a Security Hardened Kubernetes Cluster Ruleset | ||
| RulesetID = "security-hardened-k8s-cluster" |
There was a problem hiding this comment.
Suggested change
| RulesetID = "security-hardened-k8s-cluster" | |
| RulesetID = "security-hardened-k8s" |
|
|
||
| func (r *Ruleset) registerV01Rules(ruleOptions map[string]config.RuleOptionsConfig) error { // TODO: add to FromGenericConfig | ||
| _, err := client.New(r.Config, client.Options{ | ||
| Scheme: gardenerk8s.GardenScheme, |
There was a problem hiding this comment.
The scheme should be the same as the other managed k8s ruleset
| ) | ||
|
|
||
| const ( | ||
| // RulesetID is a constant containing the id of a Security Hardened Kubernetes Cluster Ruleset |
There was a problem hiding this comment.
Suggested change
| // RulesetID is a constant containing the id of a Security Hardened Kubernetes Cluster Ruleset | |
| // RulesetID is a constant containing the id of the Security Hardened Kubernetes Cluster Ruleset. |
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the
Security Hardened Kubernetes Clusterrulesetv0.1.0to themanagedk8sprovider.Which issue(s) this PR fixes:
Part of #356
Special notes for your reviewer:
Release note: