-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jobs and config for gardener-extension-provider-equinix-metal #2536
base: master
Are you sure you want to change the base?
Conversation
/assign @acumino |
The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle stale |
The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle rotten |
/remove-lifecycle rotten |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's nice that you plan to enable prow for the equinix metal extension 🙂
I'm sorry that the review took so long.
There are a couple of things to be changed apart from my review comment:
- you might want to enable branch protection similar to how it is done for cert-management as both repos still use concourse jobs.
- please add the label sync for your repository, again similar to cert-management (ref1, ref2)
- You could add your repository to the config of the lifecycle bot (ref)
- You should add
OWNERS
andOWNER_ALIASES
files to the root of your repository. There are examples how they look like in this repository. - If you like you can add your repo to the renovate config and run
make generate-prow-deployments
afterwards
- do-not-merge/release-note-label-needed | ||
- do-not-merge/work-in-progress | ||
- needs-rebase | ||
- "cla: no" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rebase please, because we deduplicated the tide config with #2609
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/kind enhancement
/kind test
What this PR does / why we need it:
We would like to use prow for gardener-extension-provider-equinix-metal related tests as well to unifi the experience