Add key and id properties to ArtefactMetadata model class
#1089
Conversation
gardener-robot
added
needs/review
gardener-robot
added
size/m
| def as_frozenset(self) -> frozenset[str]: | ||
| props = ( | ||
| @property | ||
| def key(self) -> str: |
There was a problem hiding this comment.
since key is quite imporant, and its intended use might not be obvious, I think a short docstr might be adequate (state, in particular, that key should identify this artefact-metadata uniquely, and is intended to be used as pk in underlying db)
| @@ -13,6 +14,14 @@ | |||
| import unixutil.model | |||
|
|
|||
|
|
|||
| def _as_key( | |||
There was a problem hiding this comment.
key + _as_key might be candidates for being factored into a mixin
| @property | ||
| def id(self) -> str: | ||
| return hashlib.sha1(self.key.encode('utf-8'), usedforsecurity=False).hexdigest() | ||
|
|
There was a problem hiding this comment.
as discussed recently in a different context: how about using a shorted digest + how about base64-encoding it (as opposed to hex-str) so save some more chars?
regardless: I think we should safeguard ourselves from accidentally changing this implementation via a unittest (with a comment explaining the implications of changing id-calculation)
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: