-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaned up and blocked-by-step GALA code ; many additional options #29
Open
JohnUrban
wants to merge
34
commits into
ganlab:master
Choose a base branch
from
JohnUrban:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine, more QC at each step.
…p routines, especially regarding steps 8 and 9, and all the sub-steps therein, as well as keeping certain code (in a given step needed to be executed for downstream steps) outside the if-do-step blocks where possible.
… lines outside if-statement), cleaned up code a bit.
… mode. Downstream information therein. TODO: else statement that contains only updating/creation of downstream vars.
…in flye commands due to looking for 'nanopore' in platform string instead of 'nano'. Now resolved.
…ited to do more QC checks, to launch assemblers separately, and to allow sbatch/SLURM submissions.
…op during slurmification.
…y_X.sh files. #!/bin/bash needed for sbatch.
…pace between step name and subsequent message.
…etter control over flye-polishing rounds in flye/miniasm assemblies, and whether to bother w/ polishing miniasm assemblies at all.
…ing a separate assembly.sh file for every linkagegroup (for every assembler). Will allow one to submit all to SLURM to do in parallel, not serially. I will merge this with the main gala script when I confirm it works as expected.
… assess_progress() commands inside the execution loop.
… assess_progress() commands inside the execution loop.
… assess_progress() commands inside the execution loop.
… assess_progress() commands inside the execution loop.
…lization of SLURM submissions was successful.
…d using --threads for --ntasks. Then added thread arguments directly to canu/flye/miniasm commands where relevant. Also added threads to samtools sort during the mapping step (step8).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was working with GALA back in October 2022. Many thanks for the creative tool.
Back in Oct 2022, I forked it and improved various aspects of it as far as my own needs go. I thought I'd be able to continue working on it, and eventually draw your attention to it to potentially merge, but priorities have changed and I haven't touched in in 5+ months. So I am drawing your attention to it now while the changes are still relevant and helpful. I may continue to develop on my FORK in the future, but do not foresee doing so any time soon.
Feel free to use and discard whatever updates I've made. I have checked the box that says, "Allow edits by maintainers" to give you more flexibility. Please feel free to converse here with me about any of the changes/updates.
Many of the changes I made, but I can't be sure all, are documented in
GALA/johnurban_fork_changelog.txt
:https://github.com/JohnUrban/GALA/blob/master/johnurban_fork_changelog.txt
The new options include, but may not be limited to (note - only a subset of these are currently reported in the updated
README.md
:Finally, here is a preview of how I re-organized the main GALA code into the GALA steps reported in the README -- this made it much easier to further develop and debug: