Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section on high availability setups to Galaxy Interactive Tools training #5179

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kysrpex
Copy link
Contributor

@kysrpex kysrpex commented Jul 19, 2024

Add an optional section on configuring Galaxy Interactive Tools in high availability Galaxy setups using PostgreSQL. Consider merging #5178 together with this one.

Related reads, issues and PRs (for context):

Please keep this PR as a draft until the PRs mentioned above are merged AND a new version of Galaxy is released (the latest is 24.1 at the moment of writing).

Copy link
Member

@hexylena hexylena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, some small changes needed and then happy to merge this! Thank you for documenting it!

topics/admin/tutorials/interactive-tools/tutorial.md Outdated Show resolved Hide resolved
topics/admin/tutorials/interactive-tools/tutorial.md Outdated Show resolved Hide resolved
Comment on lines 958 to 971
> > <code-in-title>SQL</code-in-title>
> > ```sql
> > ALTER DATABASE gxitproxy OWNER TO galaxy;
> > ```
> > {: data-cmd="true"}
> {: .code-in}
>
> > <code-out-title>SQL</code-out-title>
> > ```
> > ALTER DATABASE
> > ```
> {: .code-out}
>
> 4. Sign out of the `postgres` database using `exit`. Then connect to the `gxitproxy` database as `galaxy`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could replace steps 1+2+3 with the single CLI command: sudo -u postgres createdb -O galaxy gxitproxy, which would avoid students potentially missing the "logout and log in again" steps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that makes the hands-on significantly shorter too.

Addressed in 72e272f.

kysrpex and others added 2 commits July 22, 2024 11:01
…6 of HA setup section hands-on of the Galaxy Interactive Tools training

Co-authored-by: Helena <hexylena@galaxians.org>
…p section of the Galaxy Interactive Tools training
@kysrpex kysrpex marked this pull request as ready for review October 29, 2024 07:28
@kysrpex kysrpex requested a review from a team as a code owner October 29, 2024 07:28
@kysrpex
Copy link
Contributor Author

kysrpex commented Oct 29, 2024

@hexylena Upstream changes have been merged, the training can be merged now.

Comment on lines 23 to 27
- natefoo
- slugger70
- hexylena
- abretaud
- kysrpex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- natefoo
- slugger70
- hexylena
- abretaud
- kysrpex
authorship:
- natefoo
- slugger70
- hexylena
- abretaud
- kysrpex

Copy link
Contributor Author

@kysrpex kysrpex Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committed fa2d197. Does the key contributors work exactly the same as contributions?

bgruening
bgruening previously approved these changes Oct 29, 2024
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @kysrpex.

I'm just not sure if we should merge it now or if we need to wait for a proper Galaxy release.

@kysrpex
Copy link
Contributor Author

kysrpex commented Oct 29, 2024

Great, thanks @kysrpex.

I'm just not sure if we should merge it now or if we need to wait for a proper Galaxy release.

Sorry for the previous (deleted) comment, my mind was somewhere else 😅 That's ok, after all if we merge now, it would be misleading, as it would not work

@kysrpex kysrpex marked this pull request as draft October 29, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants