Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

1932 - galasabld versioning list/suffix set/suffix remove #60

Closed
wants to merge 6 commits into from

Conversation

techcobweb
Copy link
Contributor

@techcobweb techcobweb commented Jul 31, 2024

Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes but looks good - thanks

pkg/cmd/versioning.go Outdated Show resolved Hide resolved
pkg/cmd/versioningSuffixSet.go Outdated Show resolved Hide resolved
pkg/versioning/list.go Outdated Show resolved Hide resolved
@techcobweb
Copy link
Contributor Author

@jadecarino I believe I've corrected those now. Please review again ?

Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
@techcobweb
Copy link
Contributor Author

DCO checks failed. So squashing these changes into a different PR #64

@techcobweb techcobweb closed this Aug 5, 2024
@techcobweb techcobweb deleted the mcobbett-1932-galasabld-versioning branch August 15, 2024 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants