Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Fix(#161): all testscases now pass #183

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

ankostis
Copy link

@ankostis ankostis commented Jun 8, 2018

A lot of flake8 complains about builtin-named args and import * have been fixed,
apart from the usual pep8.

Note that the specific error described in #161 (iteritems() is solved by #182, but since after this there should not be anymore errors in Travis, 161 should also close with this.

@ankostis ankostis changed the title Fix(#161): complains about Fix(#161): flake8 was complaining about builtin-named args and import * Jun 8, 2018
@ankostis ankostis force-pushed the fixflake8 branch 2 times, most recently from 5956ad8 to 60908de Compare June 8, 2018 16:14
@ankostis ankostis changed the title Fix(#161): flake8 was complaining about builtin-named args and import * Fix(#161): all testscases now pass Jun 8, 2018
@ankostis
Copy link
Author

ankostis commented Jun 8, 2018

It shouold be ready to be merged

@zackmdavis
Copy link

@ankostis Did you see the "Project Abandoned" notice in the README?

@ankostis
Copy link
Author

ankostis commented Jun 8, 2018

Oups :-)

I totally missed it, was reading mostly from the readthedocs,
where this banner is not shown.
I had assumed something is not "right" though and i risked it anyway.

Also a banner issue would help,

Again, apologies for you time,
but you happen to know any forked repo, it would be appreciated?

Thnaks.

@gak
Copy link
Owner

gak commented Jun 8, 2018

No one has put up their hand to maintain a fork. I'm happy to refer users to a maintained fork.

@ankostis
Copy link
Author

ankostis commented Jun 8, 2018

Was there any debilitating design issue with this project,
that made you abandon it?

@gak
Copy link
Owner

gak commented Jun 8, 2018

No, the project is fine IIRC. Just wanted to increase my spare time for other work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants