This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 334
Fix(#161): all testscases now pass #183
Open
ankostis
wants to merge
3
commits into
gak:develop
Choose a base branch
from
ankostis:fixflake8
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankostis
changed the title
Fix(#161): complains about
Fix(#161): flake8 was complaining about builtin-named args and Jun 8, 2018
import *
ankostis
force-pushed
the
fixflake8
branch
2 times, most recently
from
June 8, 2018 16:14
5956ad8
to
60908de
Compare
ankostis
changed the title
Fix(#161): flake8 was complaining about builtin-named args and
Fix(#161): all testscases now pass
Jun 8, 2018
import *
It shouold be ready to be merged |
@ankostis Did you see the "Project Abandoned" notice in the README? |
Oups :-) I totally missed it, was reading mostly from the readthedocs, Also a banner issue would help, Again, apologies for you time, Thnaks. |
No one has put up their hand to maintain a fork. I'm happy to refer users to a maintained fork. |
Was there any debilitating design issue with this project, |
No, the project is fine IIRC. Just wanted to increase my spare time for other work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of flake8 complains about builtin-named args and
import *
have been fixed,apart from the usual pep8.
Note that the specific error described in #161 (
iteritems()
is solved by #182, but since after this there should not be anymore errors in Travis, 161 should also close with this.