Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cicd: delete stale action #290

Merged
merged 1 commit into from
Dec 15, 2023
Merged

cicd: delete stale action #290

merged 1 commit into from
Dec 15, 2023

Conversation

korikuzma
Copy link
Contributor

close #287

Will also remove the stale labels

@korikuzma korikuzma added priority:low Low priority ci/cd Continuous integration and continuous delivery/deployment changes labels Dec 5, 2023
@korikuzma korikuzma self-assigned this Dec 5, 2023
@korikuzma korikuzma requested review from a team as code owners December 5, 2023 12:45
@korikuzma
Copy link
Contributor Author

@theferrit32 @toneillbroad want to make sure you two are okay with deleting this action before merging

@jsstevenson
Copy link
Contributor

jsstevenson commented Dec 12, 2023

When can we mark this PR as stale?

Copy link
Contributor

@larrybabb larrybabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@larrybabb larrybabb merged commit 081a27c into main Dec 15, 2023
4 checks passed
@larrybabb larrybabb deleted the issue-287 branch December 15, 2023 15:37
@larrybabb
Copy link
Contributor

I merged before @theferrit32 and @toneillbroad weighed in. If they want it back I'll undo it.

@korikuzma
Copy link
Contributor Author

@larrybabb I made a comment on slack, but I think it would be good to get in the habit of squashing + merging PRs: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#squash-and-merge-your-commits

@larrybabb
Copy link
Contributor

@korikuzma sorry I missed it. I will do that from now on.

@korikuzma
Copy link
Contributor Author

@larrybabb no worries! Maybe it makes sense to include a "contributing" doc for our development practices

@larrybabb
Copy link
Contributor

@korikuzma see here. If you have ideas on how to start this, please feel free to draft it. If not, let's mention it the next time we all convene after the break and see if we can put together something simple (or copy from some other site that's already done this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continuous integration and continuous delivery/deployment changes priority:low Low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove stale action
3 participants