-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cicd: delete stale action #290
Conversation
@theferrit32 @toneillbroad want to make sure you two are okay with deleting this action before merging |
When can we mark this PR as stale? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I merged before @theferrit32 and @toneillbroad weighed in. If they want it back I'll undo it. |
@larrybabb I made a comment on slack, but I think it would be good to get in the habit of squashing + merging PRs: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#squash-and-merge-your-commits |
@korikuzma sorry I missed it. I will do that from now on. |
@larrybabb no worries! Maybe it makes sense to include a "contributing" doc for our development practices |
@korikuzma see here. If you have ideas on how to start this, please feel free to draft it. If not, let's mention it the next time we all convene after the break and see if we can put together something simple (or copy from some other site that's already done this). |
close #287
Will also remove the stale labels