FvwmPager: Use ULONG_MAX to identify a non configured Pixel. #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The black pixel is 0, so if a user configures the window foreground or focus foreground to be black, when testing if the pixel has been configured, the test fails and the pager falls back to using the pixel provided by fvwm. Instead use ULONG_MAX to identify if the window foreground and focus foreground pixel has been defined by the user or not. This fixes #1105.
ThomasAdam
added
type:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The black pixel is 0, so if a user configures the window foreground or focus foreground to be black, when testing if the pixel has been configured, the test fails and the pager falls back to using the pixel provided by fvwm. Instead use ULONG_MAX to identify if the window foreground and focus foreground pixel has been defined by the user or not.
This fixes #1105.