Fixed crash when using className with spaces in icon (#413)

* Fixed crash when using className with spaces in icon * ver up * ver up
future-architect · Nov 6, 2023 · 38db1ba · 38db1ba
1 parent 5e31f85
commit 38db1ba
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/packages/cheetah-grid/package.json b/packages/cheetah-grid/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cheetah-grid",
-  "version": "1.12.0",
+  "version": "1.12.1",
   "description": "Cheetah Grid is a high performance grid engine that works on canvas",
   "keywords": [
     "spreadsheet",

diff --git a/packages/cheetah-grid/src/js/internal/icons.ts b/packages/cheetah-grid/src/js/internal/icons.ts
@@ -79,7 +79,8 @@ export function getIconProps(
   }
   const dom =
     doms[tagName] || (doms[tagName] = document.createElement(tagName));
-  dom.classList.add(className);
+  // `classList.add()` cannot be used because it may be separated by spaces.
+  dom.className = className;
   dom.classList.add("cheetah-grid-icon");
   document.body.appendChild(dom);
   try {

diff --git a/packages/vue-cheetah-grid/package.json b/packages/vue-cheetah-grid/package.json
@@ -1,6 +1,6 @@
 {
   "name": "vue-cheetah-grid",
-  "version": "1.12.0",
+  "version": "1.12.1",
   "description": "Cheetah Grid for Vue.js",
   "main": "lib/index.js",
   "unpkg": "dist/vueCheetahGrid.js",