-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: proton-osu-bin and umu osu #213
Conversation
Apparently umu being broken is an upstream issue: Open-Wine-Components/umu-launcher#246 Also, what program is used to format? I'd like to fix the broken formatting. |
Upstream bug has been fixed and tests are now passing. Whenever umu is updated in this flake, this should be good to merge. |
Apologies for the bump, but is anything else needed for this to be merged? I've been using this branch personally with umu enabled with no problems. |
Oh, I forgot about this. Should've pinged me sooner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This PR does two things:
proton-osu-bin
package, packaged from the build artifacts of https://github.com/whrvt/umubuilder. The code is directly copied fromproton-ge-bin
in basenixpkgs
.umu
capabilities toosu-stable
, similar tostar-citizen
. This is set to use the aforementionedproton-osu
by default.Related to #207 - this doesn't directly fix
wine-osu
, but adds a new method to runosu-stable
with patches that provide the same benefit.The issue below has been solved! This PR is fully functional - I will leave the logs here for archival purposes, though.
Unfortunately, I'm currently unable to get the
useUmu
version working on my machine - the install process works fine, but the game crashes immediately after the icon splash, complaining about driver files. Here are the logs (removing extraneous logs fromgamemoderun
):Crash Log
This happens regardless of the proton version used - I've set it to
proton-ge-bin
as well for the same result.I'm unsure why this error occurs, and am submitting this PR now in hopes of getting more eyes on the problem.