Skip to content

Commit

Permalink
Introduce DeletingObject model (#243)
Browse files Browse the repository at this point in the history
  • Loading branch information
yanghua authored Oct 26, 2024
1 parent 3c6a9c9 commit c885478
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 5 deletions.
6 changes: 1 addition & 5 deletions tosfs/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
)
from tosfs.exceptions import TosfsError
from tosfs.fsspec_utils import glob_translate
from tosfs.models import DeletingObject
from tosfs.mpu import MultipartUploader
from tosfs.retry import retryable_func_executor
from tosfs.tag import BucketTagMgr
Expand Down Expand Up @@ -1358,11 +1359,6 @@ def _list_and_batch_delete_objs(self, bucket: str, key: str) -> None:
continuation_token = ""
all_results = []

class DeletingObject:
def __init__(self, key: str, version_id: Optional[str] = None):
self.key = key
self.version_id = version_id

def delete_objects(deleting_objects: List[DeletingObject]) -> None:
delete_resp = retryable_func_executor(
lambda: self.tos_client.delete_multi_objects(
Expand Down
25 changes: 25 additions & 0 deletions tosfs/models.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# ByteDance Volcengine EMR, Copyright 2024.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""The module contains models for the tosfs package."""
from typing import Optional


class DeletingObject:
"""Object to be deleted."""

def __init__(self, key: str, version_id: Optional[str] = None):
"""Initialize a DeletingObject for batch delete."""
self.key = key
self.version_id = version_id

0 comments on commit c885478

Please sign in to comment.