-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax aiobotocore versions to < 3.0.0 #829
Conversation
This relaxes the accepted aiobotocore versions to < 3.0.0 and provides a testing matrix against all recent knowmn versions, that can be extended at will.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏👏👏👏
Thank you!
awesome, thanks for the help @bolkedebruin :) |
It is too many checks to add in py3.12 too? That one would only need the most recent aiobotocore, I think. |
Let' see what it does against older aiobotocore versions - just to keep things simple. @martindurant : all green on my side |
We may trim the number of runs in the future if we start having to wait too long for CI to finish. But this will do for now. |
Awesome. Thx! |
Cool ! Thanks for that @bolkedebruin @martindurant :). That will save us quite a lot of headaches for Airflow |
Aiming for release in the next couple of days |
This relaxes the accepted aiobotocore versions
to < 3.0.0 and provides a testing matrix against
all recent knowmn versions, that can be extended
at will.
I have been a bit daring and made it < 3.0.0 as the
whole matrix passed.
The CI will provide information on what exact minor version of
aiobotocore is tested against including what boto3. As
boto3 is synced there is some backtracking done by pip,
but I kept that as it is. We could provide some hints if required
but I thought it was clearer this way.
@martindurant @freddy-fostvedt @lou-k @manugarri