Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax aiobotocore versions to < 3.0.0 #829

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

bolkedebruin
Copy link
Contributor

This relaxes the accepted aiobotocore versions
to < 3.0.0 and provides a testing matrix against
all recent knowmn versions, that can be extended
at will.

I have been a bit daring and made it < 3.0.0 as the
whole matrix passed.

The CI will provide information on what exact minor version of
aiobotocore is tested against including what boto3. As
boto3 is synced there is some backtracking done by pip,
but I kept that as it is. We could provide some hints if required
but I thought it was clearer this way.

@martindurant @freddy-fostvedt @lou-k @manugarri

This relaxes the accepted aiobotocore versions
to < 3.0.0 and provides a testing matrix against
all recent knowmn versions, that can be extended
at will.
Copy link
Contributor

@lou-k lou-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏👏👏

Thank you!

@manugarri
Copy link

awesome, thanks for the help @bolkedebruin :)

@martindurant
Copy link
Member

It is too many checks to add in py3.12 too? That one would only need the most recent aiobotocore, I think.

@bolkedebruin
Copy link
Contributor Author

bolkedebruin commented Nov 30, 2023

Let' see what it does against older aiobotocore versions - just to keep things simple.

@martindurant : all green on my side

@martindurant
Copy link
Member

We may trim the number of runs in the future if we start having to wait too long for CI to finish. But this will do for now.

@martindurant martindurant merged commit b31985d into fsspec:main Nov 30, 2023
21 checks passed
@bolkedebruin
Copy link
Contributor Author

Awesome. Thx!

@potiuk
Copy link

potiuk commented Nov 30, 2023

Cool ! Thanks for that @bolkedebruin @martindurant :). That will save us quite a lot of headaches for Airflow

@martindurant
Copy link
Member

Aiming for release in the next couple of days

@bolkedebruin bolkedebruin deleted the aio_relax branch December 1, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants