fix(api): Fixed score merge and improved related test

freelawproject · Nov 22, 2024 · d12e30b · d12e30b
1 parent a6b05f1
commit d12e30b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/cl/lib/elasticsearch_utils.py b/cl/lib/elasticsearch_utils.py
@@ -3355,5 +3355,5 @@ def set_child_docs_and_score(
             merge_highlights_into_result(meta_hl, result)
 
         # Optionally merges the BM25 score for display in the API.
-        if merge_score and isinstance(result, Response):
+        if merge_score and isinstance(result, AttrDict):
             result["bm25_score"] = result.meta.score
diff --git a/cl/tests/cases.py b/cl/tests/cases.py
@@ -270,6 +270,11 @@ async def _compare_field(
                 set(meta_expected_value.keys()),
                 f"The keys in field '{meta_field}' do not match.",
             )
+            for score_value in meta_value.values():
+                self.assertIsNotNone(
+                    score_value, f"The score value can't be None."
+                )
+
         else:
             self.assertEqual(
                 meta_value,