Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XDG_CACHE_HOME for logs #217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CameronNemo
Copy link

No description provided.

@ngie-eign
Copy link
Contributor

  • Could you please document why this change is being proposed in the commit message?
  • Could you please add Signed-off-by: to your commits?

@@ -300,7 +307,7 @@ Also, please include a copy of the log file corresponding to the problem
you are experiencing.
Unless you have changed the location of the log files, you can most likely
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is potentially misleading after this change, as the location isn't clearcut if $XDG_CACHE_HOME is not set.

@@ -317,6 +324,10 @@ The width of the screen, in number of characters.
uses this to wrap long lines.
If not present, the width of the screen is determined from the terminal
stdout is connected to, and, if the guessing fails, this defaults to infinity.
.It Va XDG_CACHE_HOME
Copy link
Contributor

@ngie-eign ngie-eign May 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's possibly duplicate/misleading text under the $HOME description below after this change.

Copy link
Contributor

@ngie-eign ngie-eign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see prior comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants