-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Leave Control Panel #809
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
requested changes
Sep 12, 2023
Codecov Report
@@ Coverage Diff @@
## develop #809 +/- ##
===========================================
+ Coverage 72.98% 73.73% +0.75%
===========================================
Files 194 195 +1
Lines 9990 10349 +359
===========================================
+ Hits 7291 7631 +340
- Misses 2699 2718 +19
|
…ustom Range instead of empty option for Dates Based On
krantheman
force-pushed
the
leave_control_panel
branch
from
September 13, 2023 11:17
125a0de
to
4244a69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- remove unused functions & fix message titles
add comments for advanced filters working
- add type hints
ruchamahabal
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: 782
Changes
Allocation of leaves via Leave Policy
Allocation of leaves by selecting Leave Type
Docs: https://frappehr.com/docs/v14/en/leave-control-panel